Skip to main content

[pkg-discuss] Re: Review request 17376567 Unable to use pkgrecv - failing with [Errno 22] Invalid argument

  • From: Xiaobo Shen < >
  • To:
  • Subject: [pkg-discuss] Re: Review request 17376567 Unable to use pkgrecv - failing with [Errno 22] Invalid argument
  • Date: Mon, 30 Sep 2013 17:18:19 -0700

On 09/30/13 03:18 PM, Tim Foster wrote:
On 10/ 1/13 07:19 AM, Xiaobo Shen wrote:
On 09/29/13 04:15 PM, Tim Foster wrote:
On 09/25/13 07:00 AM, Xiaobo Shen wrote:
On 09/24/13 11:40 AM, Xiaobo Shen wrote:

- so mention "unable to obtain or operate on lock" which might cause
administrators to investigate locking semantics on the filesystem that
contains the repository (rather than have them simply check that
permissions are correct)


Ok. I made the changes.
https://ips.java.net/webrev/xiaoshen/Bug_17376567_pkgrecv3/

Great thanks - did they pass the test suite? I ask, because it looks like you've left debugging code in at line 622 of src/modules/server/repository.py which causes a InvalidLockException("random") to always get raised in this block of code.


If it did pass the test suite, then I'm worried, and I wonder what we're doing that the test suite is unable to catch that obviously broken code - if it didn't pass the test suite, or you just forgot to run it, then that's ok (just remember to run the test suite :-)


On line 638, what does e.filename point to when the exception is raised - is it a full path to the file we attempted to lock?


src/modules/client/api_errors.py
line 408, why are you subclassing PermissionsException rather than ApiException? (and yes, I realise I made a mistake in my sample code earlier, where I called the wrong constructor)


Otherwise, the changes look good.

    cheers,
            tim





my bad. I realized I was working on the files in proto folder. Will fix it. I can change it into ApiException instead. Then we do not have self.path argument anymore. Is it ok?
It is tough to simulate a invalid argument error, but from the errno.EACCES case, I found it just report the filename instead of the full path.

xiaobo


[pkg-discuss] Re: Review request 17376567 Unable to use pkgrecv - failing with [Errno 22] Invalid argument

Xiaobo Shen 10/01/2013

[pkg-discuss] Re: Review request 17376567 Unable to use pkgrecv - failing with [Errno 22] Invalid argument

Tim Foster 10/01/2013

[pkg-discuss] Re: Review request 17376567 Unable to use pkgrecv - failing with [Errno 22] Invalid argument

Xiaobo Shen 10/01/2013

[pkg-discuss] Re: Review request 17376567 Unable to use pkgrecv - failing with [Errno 22] Invalid argument

Tim Foster 10/01/2013

[pkg-discuss] Re: Review request 17376567 Unable to use pkgrecv - failing with [Errno 22] Invalid argument

Erik Trauschke 10/01/2013

[pkg-discuss] Re: Review request 17376567 Unable to use pkgrecv - failing with [Errno 22] Invalid argument

Xiaobo Shen 10/02/2013

[pkg-discuss] Re: Review request 17376567 Unable to use pkgrecv - failing with [Errno 22] Invalid argument

Xiaobo Shen 10/25/2013

[pkg-discuss] Re: Review request 17376567 Unable to use pkgrecv - failing with [Errno 22] Invalid argument

Erik Trauschke 10/25/2013

[pkg-discuss] Re: Review request 17376567 Unable to use pkgrecv - failing with [Errno 22] Invalid argument

Xiaobo Shen 10/31/2013
 
 
Close
loading
Please Confirm
Close