Skip to main content

[pkg-discuss] Re: Code review request for 17659776 - pkg contents/search '-o pkg.fmri' should not include build_release

  • From: Yiteng Zhang < >
  • To:
  • Cc: Shawn Walker < >,
  • Subject: [pkg-discuss] Re: Code review request for 17659776 - pkg contents/search '-o pkg.fmri' should not include build_release
  • Date: Wed, 30 Oct 2013 15:23:38 -0700

On 10/29/13 08:58 AM, Shawn Walker wrote:
On 10/28/13 14:28, Yiteng Zhang wrote:
Hi all,

It is a complementary fix to the bug 16851082 build_release dropped from
pkg FMRIs and just a line of change. No unit test is affected. Let me
know your comments.

https://ips.java.net/webrev/yitezhan/17659776/

If none of the current unit tests were affected, we should likely add a unit test at least for 'pkg contents'.

-Shawn


Hi,

Test cases added for 'pkg contents' and 'pkg search'. Thank you!

https://ips.java.net/webrev/yitezhan/17659776_2/

Yiteng


[pkg-discuss] Code review request for 17659776 - pkg contents/search '-o pkg.fmri' should not include build_release

Yiteng Zhang 10/28/2013

[pkg-discuss] Re: Code review request for 17659776 - pkg contents/search '-o pkg.fmri' should not include build_release

saurabh vyas 10/29/2013

[pkg-discuss] Re: Code review request for 17659776 - pkg contents/search '-o pkg.fmri' should not include build_release

Shawn Walker 10/29/2013

[pkg-discuss] Re: Code review request for 17659776 - pkg contents/search '-o pkg.fmri' should not include build_release

Yiteng Zhang 10/30/2013
 
 
Close
loading
Please Confirm
Close