[pkg-discuss] Re: Updated sha-2 webrev
- From: Danek Duvall <
- Subject: [pkg-discuss] Re: Updated sha-2 webrev
- Date: Wed, 2 Oct 2013 15:00:46 -0700
Tim Foster wrote:
> On 10/ 2/13 12:26 PM, Tim Foster wrote:
> >> - Tim, through his tears of frustration, agreed to do the work.
> >>Tim, is that about right?
> >Yep, that's it exactly - I'll have an incremental webrev out hopefully
> >by the end of today once I've reapplied my running mascara :-)
> Ok, here we go again!
> This wad replaces pkg.elfhash.sha256 with pkg.content-type.sha256, but
> leaves 'elfhash' in place for backwards compatibility.
> It also adds pkg.filetype=elf attributes to any actions delivering ELF
> modules at publication time and stops adding the elfarch and elfbits
> attributes (we'll need to modify the pkg.5 man page accordingly)
> There will be more work needed in the source as soon as we add a new
> pkg.filetype value, to determine how to extract the correct hashable data
> from files of that particular content-type before hashing the contents, but
> I'm going to leave that for another day in the interests of getting this wad
> putback sooner rather than later.
> There's a webrev, and incremental webrev at:
I found the name CONTENT_HASH_ALGS confusing; isn't it more accurately
CONTENT_HASH_ATTRS (or _ATTR_NAMES)? Or is it just the use on line 307 of
file.py that's confusing (as I do see a RANKED_CONTENT_HASH_ATTRS defined