Skip to main content

[pkg-discuss] Re: Updated sha-2 webrev

  • From: Tim Foster < >
  • To:
  • Subject: [pkg-discuss] Re: Updated sha-2 webrev
  • Date: Thu, 03 Oct 2013 17:04:34 +1300

On 10/ 3/13 11:34 AM, Shawn Walker wrote:
I don't know if we can actually compatibly drop the elfbits and elfhash
attributes.

So in summary, Shawn was exactly right here - we can't yet :-/

I've filed a bug to fix the publication API so that we could potentially allow for pkgrecvs that do not modify any package content, or optionally drop signatures with warnings if we feel we must modify content, but we need to think about that some more.

In the meantime, I've backed out the change in this wad that dealt with elfbits, elfarch and pkg.filetype attributes and updated the webrev in place (so the incremental here shows only the changes that Danek was requesting)

https://ips.java.net/webrev/timf/sha2-webrev-4
https://ips.java.net/webrev/timf/sha2-webrev-4/sha2-webrev-4-vs-3



Once we get the publication API fixed, we can revisit dropping elfbits and elfarch and adding pkg.filetype again.

It would be good to get that fix done sooner rather than later so that the S11.x install-base is prepared, but the problem I've described will only really start hurting us when we start publishing packages with SHA-2 hashes (and then, only when we're dealing with signed packages and pkgrecv-publication that adds attributes that weren't already present: so existing s11 signed packages being pkgrecvd by a client that adds SHA2 hashes, for example would be affected)

I don't believe that it should delay this putback, so code review comments would be most welcome.

        cheers,
                        tim



[pkg-discuss] Re: Updated sha-2 webrev

(continued)

[pkg-discuss] Re: Updated sha-2 webrev

Tim Foster 10/02/2013

[pkg-discuss] Re: Updated sha-2 webrev

Danek Duvall 10/02/2013

[pkg-discuss] Re: Updated sha-2 webrev

Tim Foster 10/02/2013

[pkg-discuss] Re: Updated sha-2 webrev

Shawn Walker 10/02/2013

[pkg-discuss] Re: Updated sha-2 webrev

Tim Foster 10/02/2013

[pkg-discuss] Re: Updated sha-2 webrev

Shawn Walker 10/02/2013

[pkg-discuss] Re: Updated sha-2 webrev

Tim Foster 10/02/2013

[pkg-discuss] Re: Updated sha-2 webrev

Shawn Walker 10/02/2013

[pkg-discuss] Re: Updated sha-2 webrev

Tim Foster 10/02/2013

[pkg-discuss] Re: Updated sha-2 webrev

Shawn Walker 10/03/2013

[pkg-discuss] Re: Updated sha-2 webrev

Tim Foster 10/03/2013

[pkg-discuss] Re: Updated sha-2 webrev

Danek Duvall 10/03/2013

[pkg-discuss] Re: Updated sha-2 webrev

Tim Foster 10/03/2013

[pkg-discuss] Re: Updated sha-2 webrev

Danek Duvall 10/03/2013

[pkg-discuss] Re: Updated sha-2 webrev

Tim Foster 10/03/2013

[pkg-discuss] Re: Updated sha-2 webrev

Danek Duvall 10/03/2013
 
 
Close
loading
Please Confirm
Close