[pkg-discuss] Re: Code review: pkg verify fails for all packages containing ELF files
- From: Tim Foster <
- To: Shawn Walker <
- Subject: [pkg-discuss] Re: Code review: pkg verify fails for all packages containing ELF files
- Date: Tue, 22 Oct 2013 09:32:23 +1300
On 10/22/13 05:55 AM, Shawn Walker wrote:
Thanks for taking a look.
Are you sure the old distro import script doesn't use get_dynamic()?
I just checked, it does, but only cares about the 'deps' value of the
returned dictionary, so even if I cared about importer.py (!) this
change wouldn't affect it :-)
line 251: s/hash:/elfhash:/
Oops - I forgot to update that comment, thanks.
line 98: self.output? not self.errout?
Yep, self.output is correct: 'pkg verify' writes all output to stdout.
Otherwise, looks fine.
Cool, thanks again for jumping on this.