Skip to main content

[pkg-discuss] Re: Review request 17376567 Unable to use pkgrecv - failing with [Errno 22] Invalid argument

  • From: Erik Trauschke < >
  • To:
  • Cc: Tim Foster < >, Xiaobo Shen < >
  • Subject: [pkg-discuss] Re: Review request 17376567 Unable to use pkgrecv - failing with [Errno 22] Invalid argument
  • Date: Tue, 01 Oct 2013 15:57:49 -0700



On 10/ 1/13 03:41 PM, Tim Foster wrote:
On 10/ 2/13 06:21 AM, Xiaobo Shen wrote:
Here is a fixed one:
https://ips.java.net/webrev/xiaoshen/Bug_17376567_pkgrecv4/

That looks good.

If you could please use two blank lines between class definitions, line
407 and 417 of api_errors.py and move "e.filename" up to line 635 on
repository.py (because it'll fit within the 80-column limit), then I'm
happy with the changes.

[these are all style nits: I wish we had PEP8 checks already, which
would make life easier for new and experienced developers 17308336 :-) ]

Apart from what Tim wrote this looks good to me.
I was wondering if we need this for the repo as well but it seems like only the repo store uses an actual lock file.

I can see how this is pretty difficult to test for but is there a way to simulate an EINVAL when trying to access a file?

Erik


[pkg-discuss] Re: Review request 17376567 Unable to use pkgrecv - failing with [Errno 22] Invalid argument

Xiaobo Shen 10/01/2013

[pkg-discuss] Re: Review request 17376567 Unable to use pkgrecv - failing with [Errno 22] Invalid argument

Tim Foster 10/01/2013

[pkg-discuss] Re: Review request 17376567 Unable to use pkgrecv - failing with [Errno 22] Invalid argument

Xiaobo Shen 10/01/2013

[pkg-discuss] Re: Review request 17376567 Unable to use pkgrecv - failing with [Errno 22] Invalid argument

Tim Foster 10/01/2013

[pkg-discuss] Re: Review request 17376567 Unable to use pkgrecv - failing with [Errno 22] Invalid argument

Erik Trauschke 10/01/2013

[pkg-discuss] Re: Review request 17376567 Unable to use pkgrecv - failing with [Errno 22] Invalid argument

Xiaobo Shen 10/02/2013

[pkg-discuss] Re: Review request 17376567 Unable to use pkgrecv - failing with [Errno 22] Invalid argument

Xiaobo Shen 10/25/2013

[pkg-discuss] Re: Review request 17376567 Unable to use pkgrecv - failing with [Errno 22] Invalid argument

Erik Trauschke 10/25/2013

[pkg-discuss] Re: Review request 17376567 Unable to use pkgrecv - failing with [Errno 22] Invalid argument

Xiaobo Shen 10/31/2013
 
 
Close
loading
Please Confirm
Close