Skip to main content

[pkg-discuss] Re: Review request 2 for 15771544 pkgrepo should have a way of removing an entire publisher

  • From: Xiaobo Shen < >
  • To:
  • Subject: [pkg-discuss] Re: Review request 2 for 15771544 pkgrepo should have a way of removing an entire publisher
  • Date: Mon, 21 Oct 2013 16:19:23 -0700

On 10/21/13 10:49 AM, Erik Trauschke wrote:
On 10/21/13 10:29 AM, Xiaobo Shen wrote:
This one has been there quite a while. Let me know if anybody has more
thoughts. Thanks.

src/tests/cli/t_pkgrepo.py:
2270
    Use misc.copytree() here. No need to exec cp.

2282
There shouldn't be any difference between the temp repo you copied away and the actual repo after the removal with -n. So you should be able to just run diff and check for a return value of 0.

Otherwise this looks good to me.

Erik

Updated. Please see the following:
https://ips.java.net/webrev/xiaoshen/Bug_15771544_pkgrepo6/

Xiaobo


[pkg-discuss] Re: Review request 2 for 15771544 pkgrepo should have a way of removing an entire publisher

Xiaobo Shen 10/21/2013

[pkg-discuss] Re: Review request 2 for 15771544 pkgrepo should have a way of removing an entire publisher

Erik Trauschke 10/21/2013

[pkg-discuss] Re: Review request 2 for 15771544 pkgrepo should have a way of removing an entire publisher

Xiaobo Shen 10/21/2013

[pkg-discuss] Re: Review request 2 for 15771544 pkgrepo should have a way of removing an entire publisher

Erik Trauschke 10/22/2013
 
 
Close
loading
Please Confirm
Close