On 10/ 2/13 04:01 PM, Xiaobo Shen wrote:just a kindly reminder. This one has not get review yet.
Hi guys,I found in the bug descrition, we need to check whether stdout is a tty, but in the if condition:
I just applied the suggested fix and wrote a test case for this one. Let me know if the test case
if not os.environ.get("PKGDEPOT_CONTROLLER") and \
it actually stdin. let me know which one needs to check. Thanks.
here is a updated webrev check stdout not a tty. I forgot to put comment in the first.
[pkg-discuss] Re: Review request for 15813784 logging to stderr/stdout broken for svc:/application/pkg/server