On 10/ 1/13 05:01 PM, Xiaobo Shen wrote:
On 10/ 1/13 03:57 PM, Erik Trauschke wrote:Let me if anybody has more suggestions about this one. Thanks
I did some experiments previously but did not find a easy way to
On 10/ 1/13 03:41 PM, Tim Foster wrote:
On 10/ 2/13 06:21 AM, Xiaobo Shen wrote:
Here is a fixed one:
That looks good.
If you could please use two blank lines between class definitions, line
407 and 417 of api_errors.py and move "e.filename" up to line 635 on
repository.py (because it'll fit within the 80-column limit), then I'm
happy with the changes.
[these are all style nits: I wish we had PEP8 checks already, which
would make life easier for new and experienced developers 17308336
Apart from what Tim wrote this looks good to me.
I was wondering if we need this for the repo as well but it seems
like only the repo store uses an actual lock file.
I can see how this is pretty difficult to test for but is there a way
to simulate an EINVAL when trying to access a file?
trigger it. Might require some run-time interactions. Let me know if
you guys know how to.
here is an updated webrev for just at the current stage:
[pkg-discuss] Re: Review request 17376567 Unable to use pkgrecv - failing with [Errno 22] Invalid argument