Skip to main content

[pkg-discuss] Re: Code review request: 15753020 pkg set-publisher --disable fails if ssl certificate is expired

  • From: Erik Trauschke < >
  • To:
  • Cc: Shawn Walker < >
  • Subject: [pkg-discuss] Re: Code review request: 15753020 pkg set-publisher --disable fails if ssl certificate is expired
  • Date: Mon, 16 Dec 2013 14:54:27 -0800



On 12/16/13 02:03 PM, Shawn Walker wrote:
On 12/16/13 02:30, Thejaswini wrote:
Hi,

Please review the code at
https://ips.java.net/webrev/tk241774/ssl_expire/01/

This contains the fix for bug 15753020 pkg set-publisher --disable fails
if ssl certificate is expired

Let me know your comments/suggestions.

src/client.py:
   This is the wrong place to apply the fix; revert all changes here.
   The changes also do more than just ignore expiring certificates.

   Instead, what should be happening is that we completely ignore
   any ExpiringCertificate exceptions when disabling a publisher.

   So the real fix likely needs to be applied somewhere in
   api.py:__update_publisher().

   What's strange though is that we're already catching
   ExpiringCertificate errors there and simply logging them.  So
   I wonder if this bug is still valid.


src/tests/...:
   This isn't actually testing the expiring case.  I would use the
   changes Yiteng made for 17913496 to
src/tests/cli/t_pkg_temp_sources.py as a basis for testing this case.

Actually, the change you are looking for is part of 17768096. Once this goes back it will allow to create an expiring certificate from a test case very easily.

Erik


[pkg-discuss] Code review request: 15753020 pkg set-publisher --disable fails if ssl certificate is expired

Thejaswini 12/16/2013

[pkg-discuss] Re: Code review request: 15753020 pkg set-publisher --disable fails if ssl certificate is expired

Shawn Walker 12/16/2013

[pkg-discuss] Re: Code review request: 15753020 pkg set-publisher --disable fails if ssl certificate is expired

Erik Trauschke 12/16/2013

[pkg-discuss] Re: Code review request: 15753020 pkg set-publisher --disable fails if ssl certificate is expired

Thejaswini 12/17/2013
 
 
Close
loading
Please Confirm
Close