On 12/16/13 02:30, Thejaswini wrote:
Please review the code at
This contains the fix for bug 15753020 pkg set-publisher --disable fails
if ssl certificate is expired
Let me know your comments/suggestions.
This is the wrong place to apply the fix; revert all changes here.
The changes also do more than just ignore expiring certificates.
Instead, what should be happening is that we completely ignore
any ExpiringCertificate exceptions when disabling a publisher.
So the real fix likely needs to be applied somewhere in
What's strange though is that we're already catching
ExpiringCertificate errors there and simply logging them. So
I wonder if this bug is still valid.
This isn't actually testing the expiring case. I would use the
changes Yiteng made for 17913496 to
src/tests/cli/t_pkg_temp_sources.py as a basis for testing this case.
[pkg-discuss] Re: Code review request: 15753020 pkg set-publisher --disable fails if ssl certificate is expired