Skip to main content

[pkg-discuss] Re: Code review request for 17913496 certificates for test suite are expiring

  • From: Yiteng Zhang < >
  • To:
  • Cc: , Erik Trauschke < >
  • Subject: [pkg-discuss] Re: Code review request for 17913496 certificates for test suite are expiring
  • Date: Fri, 13 Dec 2013 10:40:18 -0800

On 12/13/13 10:25 AM, Danek Duvall wrote:
Yiteng Zhang wrote:

Hi,

For this one, I regenerated the certificates and keys with updated validate
duration for test suite. Please see the following link and let me know your
comments.

https://ips.java.net/webrev/yitezhan/17913496/
Why the changes to generate_certs?
Hi,

To change generate_certs.py is to keep the generated keys stored in the old format, which is created by OpenSSl 0.9.8 and not encrypted. The problem is when I use the original generate_certs.py file, it would use OpenSSl 1.0.0 and generate the keys in an encrypted format. And since Apache has no support for encrypted private keys currently, refer to http://httpd.apache.org/docs/2.2/mod/mod_ssl.html#sslproxymachinecertificatefile, Apache can not read the encrypted keys and would fail. Thanks to Erik pointing out this issue.

I agree with Erik that it'd be nice to have this done automatically, but
doing it in such a way that it doesn't rebuild all the certs every time you
run any tests is probably more than we need right now.

I agree too. Regenerating the certs every time also make the webrev more complicated.
Thanks,
Danek

Thanks,
Yiteng




[pkg-discuss] Code review request for 17913496 certificates for test suite are expiring

Yiteng Zhang 12/13/2013

[pkg-discuss] Re: Code review request for 17913496 certificates for test suite are expiring

Erik Trauschke 12/13/2013

[pkg-discuss] Re: Code review request for 17913496 certificates for test suite are expiring

Danek Duvall 12/13/2013

[pkg-discuss] Re: Code review request for 17913496 certificates for test suite are expiring

Erik Trauschke 12/13/2013

[pkg-discuss] Re: Code review request for 17913496 certificates for test suite are expiring

Yiteng Zhang 12/13/2013

[pkg-discuss] Re: Code review request for 17913496 certificates for test suite are expiring

Erik Trauschke 12/13/2013

[pkg-discuss] Re: Code review request for 17913496 certificates for test suite are expiring

Erik Trauschke 12/13/2013

[pkg-discuss] Re: Code review request for 17913496 certificates for test suite are expiring

Yiteng Zhang 12/13/2013

[pkg-discuss] Re: Code review request for 17913496 certificates for test suite are expiring

Danek Duvall 12/13/2013

[pkg-discuss] Re: Code review request for 17913496 certificates for test suite are expiring

Erik Trauschke 12/13/2013

[pkg-discuss] Re: Code review request for 17913496 certificates for test suite are expiring

Danek Duvall 12/13/2013

[pkg-discuss] Re: Code review request for 17913496 certificates for test suite are expiring

Erik Trauschke 12/14/2013

[pkg-discuss] Re: Code review request for 17913496 certificates for test suite are expiring

Danek Duvall 12/14/2013

[pkg-discuss] Re: Code review request for 17913496 certificates for test suite are expiring

Erik Trauschke 12/14/2013

[pkg-discuss] Re: Code review request for 17913496 certificates for test suite are expiring

Yiteng Zhang 12/16/2013
 
 
Close
loading
Please Confirm
Close