Skip to main content

[pkg-discuss] Re: [review] trivial test suite fix

  • From: Danek Duvall < >
  • To:
  • Subject: [pkg-discuss] Re: [review] trivial test suite fix
  • Date: Thu, 27 Feb 2014 10:51:29 -0800

Shawn Walker wrote:

> Greetings,
> 
> The following trivial fix resolves a test suite issue:
> 
>   16541274 compiler change off 12.1 breaks
>            TestPkgdepBasics.test_elf_dependency_tags
> 
> Put simply, Studio 12.1 automatically linked libc to shared objects
> (libraries?); Studio 12.2+ does not.
> 
> To ensure the same result regardless of which version of compiler is being
> used, I've simply changed it to always link to libc.

Is there a reason you didn't put that in the "if shared_lib" clause?  The
man page, at least, indicates that this behavior is tied to -G.

Thanks,
Danek

> -Shawn
> 
> # HG changeset patch
> # User Shawn Walker 
> < >
> # Date 1393526280 28800
> #      Thu Feb 27 10:38:00 2014 -0800
> # Node ID 54396ccfad74f023f36a710cf4a5bfba859c5bdc
> # Parent  4288ad6884e3b2c2122ca4b8a89536999786495f
> 16541274 compiler change off 12.1 breaks
> TestPkgdepBasics.test_elf_dependency_tags
> 
> diff --git a/src/tests/cli/t_pkgdep.py b/src/tests/cli/t_pkgdep.py
> --- a/src/tests/cli/t_pkgdep.py
> +++ b/src/tests/cli/t_pkgdep.py
> @@ -1025,6 +1025,8 @@ file NOHASH group=bin mode=0555 owner=ro
>                  # Make sure to quote the runpaths, as they may contain
> tokens
>                  # like $PLATFORM which we do not want the shell to
> evaluate.
>                  opts = ["-R'%s'" % rp for rp in run_paths]
> +                # Always link to libc; the compiler may not.
> +                opts.append("-lc")
>                  if bit64:
>                          opts.append("-m64")
>                  if shared_lib:


[pkg-discuss] [review] trivial test suite fix

Shawn Walker 02/27/2014

[pkg-discuss] Re: [review] trivial test suite fix

Bart Smaalders 02/27/2014

<Possible follow-up(s)>

[pkg-discuss] [review] trivial test suite fix

Shawn Walker 02/27/2014

[pkg-discuss] Re: [review] trivial test suite fix

Danek Duvall 02/27/2014

[pkg-discuss] Re: [review] trivial test suite fix

Shawn Walker 02/27/2014

[pkg-discuss] Re: [review] trivial test suite fix

Danek Duvall 02/27/2014
 
 
Close
loading
Please Confirm
Close