Skip to main content

[pkg-discuss] Re: [review] trivial test suite fix

  • From: Danek Duvall < >
  • To: Shawn Walker < >
  • Cc:
  • Subject: [pkg-discuss] Re: [review] trivial test suite fix
  • Date: Thu, 27 Feb 2014 10:58:34 -0800

Shawn Walker wrote:

> On 02/27/14 10:51, Danek Duvall wrote:
> >Shawn Walker wrote:
> >
> >>Greetings,
> >>
> >>The following trivial fix resolves a test suite issue:
> >>
> >>   16541274 compiler change off 12.1 breaks
> >>            TestPkgdepBasics.test_elf_dependency_tags
> >>
> >>Put simply, Studio 12.1 automatically linked libc to shared objects
> >>(libraries?); Studio 12.2+ does not.
> >>
> >>To ensure the same result regardless of which version of compiler is being
> >>used, I've simply changed it to always link to libc.
> >
> >Is there a reason you didn't put that in the "if shared_lib" clause?  The
> >man page, at least, indicates that this behavior is tied to -G.
> 
> Ah, no, I thought it was more general, but you're right.
> 
> I've moved it to the "if shared_lib:" clause and tested with both Studio
> 12.1 and Studio 12.3; it works as expected.

+1

Thanks,
Danek


[pkg-discuss] [review] trivial test suite fix

Shawn Walker 02/27/2014

[pkg-discuss] Re: [review] trivial test suite fix

Bart Smaalders 02/27/2014

<Possible follow-up(s)>

[pkg-discuss] [review] trivial test suite fix

Shawn Walker 02/27/2014

[pkg-discuss] Re: [review] trivial test suite fix

Danek Duvall 02/27/2014

[pkg-discuss] Re: [review] trivial test suite fix

Shawn Walker 02/27/2014

[pkg-discuss] Re: [review] trivial test suite fix

Danek Duvall 02/27/2014
 
 
Close
loading
Please Confirm
Close