Skip to main content

[pkg-discuss] Re: [review] 18323807 SMF actuators fail if getting passed lists instead of tuples

  • From: Erik Trauschke < >
  • To:
  • Cc: Danek Duvall < >
  • Subject: [pkg-discuss] Re: [review] 18323807 SMF actuators fail if getting passed lists instead of tuples
  • Date: Thu, 27 Feb 2014 14:00:48 -0800



On 02/27/14 01:55 PM, Danek Duvall wrote:
Erik Trauschke wrote:

Hi folks,

this is a really simple code review request for the fix for 18323807.

In my sync actuators putback I removed the explicit cast into tuple for the
FMRI lists getting passed to the SMF actuators. This fix puts them back in.

Looks like it'd been broken for enable and disable before, anyway.

I also added test cases for this.

https://ips.java.net/webrev/etrausch/18323807_smf_act/

LGTM.

Will this affect any installation or upgrade of a package on a live build
42 BE which wants to refresh or restart a service (such as manifest-import
or man-index), or will this only happen when an action has more than one
actuator of the same type?  It's probably worth a flag-day notice, if we
know what's going to be affected.

It only happens when we call save_config() in image.py. For some reason it passes a single SMF FMRI as a list which will screw up the actuators.

I'm currently trying to reproduce when this happens and will inform you once I know more.

Erik


[pkg-discuss] [review] 18323807 SMF actuators fail if getting passed lists instead of tuples

Erik Trauschke 02/27/2014

[pkg-discuss] Re: [review] 18323807 SMF actuators fail if getting passed lists instead of tuples

Shawn Walker 02/27/2014

[pkg-discuss] Re: [review] 18323807 SMF actuators fail if getting passed lists instead of tuples

Erik Trauschke 02/27/2014

[pkg-discuss] Re: [review] 18323807 SMF actuators fail if getting passed lists instead of tuples

Danek Duvall 02/27/2014

[pkg-discuss] Re: [review] 18323807 SMF actuators fail if getting passed lists instead of tuples

Erik Trauschke 02/27/2014
 
 
Close
loading
Please Confirm
Close