Skip to main content

[pkg-discuss] Re: code review request: pkg dehydrate/rehydrate

  • From: Yiteng Zhang < >
  • To:
  • Cc: Bart Smaalders < >, Erik Trauschke < >, Shawn Walker < >, Danek Duvall < >
  • Subject: [pkg-discuss] Re: code review request: pkg dehydrate/rehydrate
  • Date: Thu, 19 Jun 2014 11:55:03 -0700

Hi all,

As discussed in the pkg meeting, I implemented most of the idea we agreed on.
It will be fast to have a review on this webrev if you take a look on the following
notes:
1) "dehydrated" property with the value of dehydrated publishers will be set
on the image, and it will be deleted if all publishers are rehydrated.

2) Any pkg operation are allowed after pkg dehydrate/rehydrate and tested.

3) dehydrate will *not* check the "dehydrated" property, so dehydrate will always
go through all the specified and configured publishers even they were marked as
"dehydrated". Then dehydrate will check the existence of the files that are supposed
to remove. If they exist, propose them to remove. If not, do nothing.

4) rehydrate will check the "dehydrated" property. If a publisher has been marked as
"dehydrated", it will install the removed files from this publisher. If not, it does nothing
about this publisher. Then rehydrate will *not* check the existence of the files that
are supposed to install, so rehydrate will always install them.

5) For pkg fix, I implemented an approach for printing stuff like this: defined some abstract
methods in ProgressTrackerBackend and ProgressTrackerFrontend, and override these
methods in their subclasses(ProgressTracker, CommandLineProgressTracker and
FancyUNIXProgressTracker). I think it is consistent with the way we do for pkg verify.

incremental: https://ips.java.net/webrev/yitezhan/pkg_hydrate-2on1/
webrev: https://ips.java.net/webrev/yitezhan/pkg_hydrate-2/

on-12clone webrev: https://ips.java.net/webrev/yitezhan/on12-clone-hydrate/

Thanks,
Yiteng


[pkg-discuss] Re: code review request: pkg dehydrate/rehydrate

Bart Smaalders 06/05/2014

[pkg-discuss] Re: code review request: pkg dehydrate/rehydrate

Yiteng Zhang 06/05/2014

[pkg-discuss] Re: code review request: pkg dehydrate/rehydrate

Yiteng Zhang 06/09/2014

[pkg-discuss] Re: code review request: pkg dehydrate/rehydrate

Yiteng Zhang 06/13/2014

[pkg-discuss] Re: code review request: pkg dehydrate/rehydrate

Yiteng Zhang 06/19/2014

[pkg-discuss] Re: code review request: pkg dehydrate/rehydrate

Danek Duvall 06/23/2014

[pkg-discuss] Re: code review request: pkg dehydrate/rehydrate

Yiteng Zhang 06/24/2014

[pkg-discuss] Re: code review request: pkg dehydrate/rehydrate

Shawn Walker 06/26/2014

[pkg-discuss] Re: code review request: pkg dehydrate/rehydrate

Yiteng Zhang 06/26/2014

[pkg-discuss] Re: code review request: pkg dehydrate/rehydrate

Shawn Walker 06/26/2014

[pkg-discuss] Re: code review request: pkg dehydrate/rehydrate

Danek Duvall 06/26/2014

[pkg-discuss] Re: code review request: pkg dehydrate/rehydrate

Shawn Walker 06/26/2014

[pkg-discuss] Re: code review request: pkg dehydrate/rehydrate

Danek Duvall 06/26/2014

[pkg-discuss] Re: code review request: pkg dehydrate/rehydrate

Shawn Walker 06/26/2014

Message not available

Message not available

[pkg-discuss] Re: code review request: pkg dehydrate/rehydrate

Yiteng Zhang 06/25/2014
 
 
Close
loading
Please Confirm
Close