Skip to main content

[pkg-discuss] Re: code review request: pkg dehydrate/rehydrate

  • From: Shawn Walker < >
  • To: Danek Duvall < >
  • Cc: Yiteng Zhang < >, , Bart Smaalders < >, Erik Trauschke < >
  • Subject: [pkg-discuss] Re: code review request: pkg dehydrate/rehydrate
  • Date: Thu, 26 Jun 2014 11:53:07 -0700

On 06/26/14 11:49, Danek Duvall wrote:
Shawn Walker wrote:

On 06/26/14 11:25, Danek Duvall wrote:
Yiteng Zhang wrote:

On 06/23/14 04:08 PM, Danek Duvall wrote:
Yiteng Zhang wrote:
...
   - line 4490, 4491: why is this check here?

I knew api will have this check in execute(), but the old pkg fix had
this check at the very beginning of method __repair() and __repair() also
invoked execute(). I inclined to remove this check here though.

Yeah.  I'd like Shawn to comment on that, but I don't think it's needed
anymore.

The check is still needed in the case that we change the image format again
in the future.

It's basically just there to say "I can't repair this image unless you
upgrade its format first".

And that's not needed for other operations?

This method is different from the others in a way that's, at least to me,
non-obvious.  If there's something special about fix that requires an image
version check, there should be a comment explaining why it's special.

Hmmm...it looks like this was primarily there because it was originally in image.py and didn't go through the imageplan.

Now that we actually go through the imageplan, as long as preexecute() is triggered, we should be safe.

So the check is only needed still if we don't pass through preexecute().

-Shawn


[pkg-discuss] Re: code review request: pkg dehydrate/rehydrate

(continued)

[pkg-discuss] Re: code review request: pkg dehydrate/rehydrate

Yiteng Zhang 06/13/2014

[pkg-discuss] Re: code review request: pkg dehydrate/rehydrate

Yiteng Zhang 06/19/2014

[pkg-discuss] Re: code review request: pkg dehydrate/rehydrate

Danek Duvall 06/23/2014

[pkg-discuss] Re: code review request: pkg dehydrate/rehydrate

Yiteng Zhang 06/24/2014

[pkg-discuss] Re: code review request: pkg dehydrate/rehydrate

Shawn Walker 06/26/2014

[pkg-discuss] Re: code review request: pkg dehydrate/rehydrate

Yiteng Zhang 06/26/2014

[pkg-discuss] Re: code review request: pkg dehydrate/rehydrate

Shawn Walker 06/26/2014

[pkg-discuss] Re: code review request: pkg dehydrate/rehydrate

Danek Duvall 06/26/2014

[pkg-discuss] Re: code review request: pkg dehydrate/rehydrate

Shawn Walker 06/26/2014

[pkg-discuss] Re: code review request: pkg dehydrate/rehydrate

Danek Duvall 06/26/2014

[pkg-discuss] Re: code review request: pkg dehydrate/rehydrate

Shawn Walker 06/26/2014

Message not available

Message not available

[pkg-discuss] Re: code review request: pkg dehydrate/rehydrate

Yiteng Zhang 06/25/2014

[pkg-discuss] Re: code review request: pkg dehydrate/rehydrate

Shawn Walker 06/25/2014

[pkg-discuss] Re: code review request: pkg dehydrate/rehydrate

Shawn Walker 06/25/2014

[pkg-discuss] Re: code review request: pkg dehydrate/rehydrate

Danek Duvall 06/27/2014

[pkg-discuss] Re: code review request: pkg dehydrate/rehydrate

Shawn Walker 06/26/2014

[pkg-discuss] Re: code review request: pkg dehydrate/rehydrate

Erik Trauschke 06/06/2014

[pkg-discuss] Re: code review request: pkg dehydrate/rehydrate

Yiteng Zhang 06/06/2014

[pkg-discuss] Re: code review request: pkg dehydrate/rehydrate

Erik Trauschke 06/06/2014
 
 
Close
loading
Please Confirm
Close