Skip to main content

[JIRA] Issue Comment Edited: (JAVAMONEY-58) Currency data source URL for IsoCurrencyOnlineProvider needs updating

  • From: "keilw (JIRA)" <jira-no-reply@...>
  • To: issues@...
  • Subject: [JIRA] Issue Comment Edited: (JAVAMONEY-58) Currency data source URL for IsoCurrencyOnlineProvider needs updating
  • Date: Mon, 12 Aug 2013 16:59:02 +0000 (UTC)
  • Auto-submitted: auto-generated


    [ 
https://java.net/jira/browse/JAVAMONEY-58?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=367427#action_367427
 ] 

keilw edited comment on JAVAMONEY-58 at 8/12/13 4:58 PM:
---------------------------------------------------------

As a first step I'm fixing the URL to the new version. Where CI server 
(Jenkins) would also allow us to run Integration Tests there should be some 
for external services such as this to flag whenever this or another URL 
changes in future.
Will externalize it into a properties file for easier maintenance, but 
ultimate customization should be possible similar to Java 7+ Currency class:
>Users can supersede the Java runtime currency data by creating a properties 
>file named <JAVA_HOME>/lib/currency.properties. The contents of the 
>properties file are key/value pairs of the ISO 3166 country codes and the 
>ISO 4217 currency data respectively. >The value part consists of three ISO 
>4217 values of a currency, i.e., an alphabetic code, a numeric code, and a 
>minor unit. Those three
>ISO 4217 values are separated by commas. The lines which start with '#'s are 
>considered comment lines. For example,...

either we'd use this file or introduce another one or two additional files 
(not too many, otherwise it gets confusing and we'd have a Spring-like maze 
of properties;-)

      was (Author: keilw):
    As a first step I'm fixing the URL to the new version. Where CI server 
(Jenkins) would also allow us to run Integration Tests there should be some 
for external services such as this to flag whenever this or another URL 
changes in future.
Will externalize it into a properties file for easier maintenance, but 
ultimate customization should be possible similar to Java 7+ Currency class:
>Users can supersede the Java runtime currency data by creating a properties 
>file named <JAVA_HOME>/lib/currency.properties. The contents of the 
>properties file are key/value pairs of the ISO 3166 country codes and the 
>ISO 4217 currency data respectively. The >value part consists of three ISO 
>4217 values of a currency, i.e., an alphabetic code, a numeric code, and a 
>minor unit. Those three
>ISO 4217 values are separated by commas. The lines which start with '#'s are 
>considered comment lines. For example,...

either we'd use this file or introduce another one or two additional files 
(not too many, otherwise it gets confusing and we'd have a Spring-like maze 
of properties;-)
  
> Currency data source URL for IsoCurrencyOnlineProvider needs updating
> ---------------------------------------------------------------------
>
>                 Key: JAVAMONEY-58
>                 URL: https://java.net/jira/browse/JAVAMONEY-58
>             Project: javamoney
>          Issue Type: Bug
>          Components: Ext: Provided Extensions
>            Reporter: paulkmoore
>            Assignee: keilw
>            Priority: Minor
>
> The URL which specifies the location of the currency source in 
> net.java.javamoney.ri.ext.provider.iso.IsoCurrencyOnlineProvider#loadCurrencies
>  method is no longer valid.  The current source is:
> {code}
> http://www.currency-iso.org/dam/isocy/downloads/dl_iso_table_a1.xml
> {code}
> which results in an Http 404.
> I believe the replacement should be:
> {code}
> http://www.currency-iso.org/dam/downloads/table_a1.xml
> {code}

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
https://java.net/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        


[JIRA] Created: (JAVAMONEY-58) Currency data source URL for IsoCurrencyOnlineProvider needs updating

paulkmoore (JIRA) 08/12/2013

[JIRA] Assigned: (JAVAMONEY-58) Currency data source URL for IsoCurrencyOnlineProvider needs updating

keilw (JIRA) 08/12/2013

[JIRA] Work started: (JAVAMONEY-58) Currency data source URL for IsoCurrencyOnlineProvider needs updating

keilw (JIRA) 08/12/2013

[JIRA] Commented: (JAVAMONEY-58) Currency data source URL for IsoCurrencyOnlineProvider needs updating

keilw (JIRA) 08/12/2013

[JIRA] Issue Comment Edited: (JAVAMONEY-58) Currency data source URL for IsoCurrencyOnlineProvider needs updating

keilw (JIRA) 08/12/2013

[JIRA] Issue Comment Edited: (JAVAMONEY-58) Currency data source URL for IsoCurrencyOnlineProvider needs updating

keilw (JIRA) 08/12/2013

[JIRA] Issue Comment Edited: (JAVAMONEY-58) Currency data source URL for IsoCurrencyOnlineProvider needs updating

keilw (JIRA) 08/12/2013

[JIRA] Issue Comment Edited: (JAVAMONEY-58) Currency data source URL for IsoCurrencyOnlineProvider needs updating

keilw (JIRA) 08/12/2013

[JIRA] Commented: (JAVAMONEY-58) Currency data source URL for IsoCurrencyOnlineProvider needs updating

keilw (JIRA) 08/13/2013

[JIRA] Commented: (JAVAMONEY-58) Currency data source URL for IsoCurrencyOnlineProvider needs updating

paulkmoore (JIRA) 08/13/2013

[JIRA] Issue Comment Edited: (JAVAMONEY-58) Currency data source URL for IsoCurrencyOnlineProvider needs updating

paulkmoore (JIRA) 08/13/2013
 
 
Close
loading
Please Confirm
Close