Skip to main content

[JSR-354] Re: TCK tests finished in a first release

  • From: Werner Keil <werner.keil@...>
  • To: "jcurrency_mail@..." <jcurrency_mail@...>
  • Subject: [JSR-354] Re: TCK tests finished in a first release
  • Date: Thu, 5 Jun 2014 18:30:18 +0200

Math/StrictMath are areas, where JSR 363 EG Member Martin provided fixes
and improvements to Java 8[?]

There are places in the JSR 363 RI like intValue(Unit) where we also throw
ArithmeticException rather than MeasurementException or a specialized form.
And in at least one case, a Checked Exception in the API also doesn't
inherit from MeasurementException, which uses RuntimeException[?]

Werner

On Thu, Jun 5, 2014 at 6:08 PM, Stephen Colebourne <scolebourne@...>
wrote:

> JSR-310 uses ArithmeticException for overflows. This is encoded into
> the new methods added to the Math class in JDK 8. I'd strongly suggest
> that MonetaryException isn't what you want here.
>
> Stephen
>
> On 4 June 2014 07:19, Anatole Tresch <atsticks@...> wrote:
> > Dear all,
> >
> > just wanted to inform you that I have all TCK tests implemented so far. I
> > will have to go over the TCK again, e.g. during some Hackergarten events
> and
> > add more test messages and more detailed Javadoc. Also the TCK must be
> > repackaged, so it can be easily combined with an arbitrary implementation
> > and yes, there must be some TCK guide written (already started in
> asciidoc).
> > But I think this is an important step.
> > Also with the current RO all test now run green.
> >
> > From the code side there is basically only one small adaptation on the
> spec,
> > I would propose:
> >
> > Currently the spec defines at some locations that MonetaryAmount
> > implementation must throw an ArithemticException, when the amounts
> operated
> > exceed the internal capabilities. I would suggest to change this to
> throw a
> > MonetaryException instead of. It makes life easier for developers,
> because
> > they can focus on catching MonetaryException only and do not need to have
> > know how in where an ArithemticException may be thrown or not.
> Additionally
> > it is also clear, that when a MonetaryException is thrown it must have
> its
> > origin in the money API, which makes analysis simpler.
> >
> > WDYT?
> >
> > Cheers,
> > Anatole
> >
> >
> > --
> > Anatole Tresch
> > Java Lead Engineer, JSR Spec Lead
> > Glärnischweg 10
> > CH - 8620 Wetzikon
> >
> > Switzerland, Europe Zurich, GMT+1
> > Twitter:  @atsticks
> > Blogs: http://javaremarkables.blogspot.ch/
> > Google: atsticks
> > Mobile  +41-76 344 62 79
>

Attachment: 329.gif
Description: GIF image

Attachment: 347.gif
Description: GIF image



[JSR-354] TCK tests finished in a first release

Anatole Tresch 06/04/2014

[JSR-354] Re: TCK tests finished in a first release

Simon Martinelli 06/04/2014

[JSR-354] Re: TCK tests finished in a first release

Werner Keil 06/04/2014

[JSR-354] Re: TCK tests finished in a first release

Daniel Bryant 06/05/2014

[JSR-354] Re: TCK tests finished in a first release

tom.huesler@... 06/04/2014

[JSR-354] Re: TCK tests finished in a first release

Otávio Gonçalves de Santana 06/04/2014

[JSR-354] Re: TCK tests finished in a first release

Mohamed Taman 06/04/2014

[JSR-354] Re: TCK tests finished in a first release

Anatole Tresch 06/04/2014

[JSR-354] Re: TCK tests finished in a first release

Stephen Colebourne 06/05/2014

[JSR-354] Re: TCK tests finished in a first release

Werner Keil 06/05/2014

[JSR-354] Re: TCK tests finished in a first release

Tresch, Anatole 06/10/2014
 
 
Close
loading
Please Confirm
Close