Skip to main content

[memorypoolview~source-code-repository:05aceef1] added explicit support for J9 memory pools

  • From:
  • To:
  • Subject: [memorypoolview~source-code-repository:05aceef1] added explicit support for J9 memory pools
  • Date: Mon, 31 Dec 2012 13:14:32 +0000

Project:    memorypoolview
Repository: source-code-repository
Revision:   05aceef1ffd34ab42c5a2b0ce8b832f9000418ea
Author:     kcpeppe
Date:       2012-12-31 09:32:34 UTC
Link:       

Log Message:
------------
added explicit support for J9 memory pools


Revisions:
----------
05aceef1ffd34ab42c5a2b0ce8b832f9000418ea


Modified Paths:
---------------
src/com/kodewerk/visualvm/memorypools/MemoryPoolView.java


Diffs:
------
diff --git a/src/com/kodewerk/visualvm/memorypools/MemoryPoolView.java 
b/src/com/kodewerk/visualvm/memorypools/MemoryPoolView.java
index 2598c46..68bfcbe 100644
--- a/src/com/kodewerk/visualvm/memorypools/MemoryPoolView.java
+++ b/src/com/kodewerk/visualvm/memorypools/MemoryPoolView.java
@@ -102,8 +102,9 @@ class MemoryPoolView extends DataSourceView {
     protected void findMemoryPools() {
         try {
             MBeanServerConnection conn = getMBeanServerConnection( 
(Application)super.getDataSource());
-            for (ObjectName name : 
conn.queryNames(getMemoryPoolWildcardPattern(), null))
+            for (ObjectName name : 
conn.queryNames(getMemoryPoolWildcardPattern(), null)) {
                 initializeModel(name, conn);
+            }
         } catch (IOException e) {
             Exceptions.printStackTrace(e);
         }
@@ -144,7 +145,7 @@ class MemoryPoolView extends DataSourceView {
         Point point = positions.get(name);
         if ( point == null) {
             point = new Point( corner, order++);
-            corner = ( corner + 1) % 4;
+            corner = (corner == 5) ? 1 : corner++;
         }
         return point;
     }
@@ -170,5 +171,12 @@ class MemoryPoolView extends DataSourceView {
         positions.put( "PS Perm Gen", new 
Point(DataViewComponent.BOTTOM_LEFT,10));
         positions.put( "G1 Perm Gen", new 
Point(DataViewComponent.BOTTOM_LEFT,10));
         positions.put( "Code Cache", new 
Point(DataViewComponent.BOTTOM_RIGHT,10));
+        
+        //IBM Memory Pool Names
+        positions.put( "Java heap", new Point(DataViewComponent.TOP_LEFT, 
10));
+        positions.put( "class storage", new 
Point(DataViewComponent.TOP_RIGHT, 10));
+        positions.put( "miscellaneous non-heap storage", new 
Point(DataViewComponent.BOTTOM_LEFT, 10));
+        positions.put( "JIT code cache", new 
Point(DataViewComponent.BOTTOM_RIGHT, 10));
+        positions.put( "JIT data cache", new 
Point(DataViewComponent.BOTTOM_RIGHT, 20));
     }
 }




[memorypoolview~source-code-repository:05aceef1] added explicit support for J9 memory pools

kcpeppe 12/31/2012
 
 
Close
loading
Please Confirm
Close