Skip to main content

[memorypoolview~source-code-repository:66b11d5e] Adjusted GC graphs alignment. Young GC is top, Old/Full GC is bottom.

  • From:
  • To:
  • Subject: [memorypoolview~source-code-repository:66b11d5e] Adjusted GC graphs alignment. Young GC is top, Old/Full GC is bottom.
  • Date: Tue, 16 Apr 2013 20:31:13 +0000

Project:    memorypoolview
Repository: source-code-repository
Revision:   66b11d5e8b9a015dd1b917981d9a03564bc6f16e
Author:     pingtimeout
Date:       2013-04-16 20:29:29 UTC
Link:       

Log Message:
------------
Adjusted GC graphs alignment. Young GC is top, Old/Full GC is bottom.


Revisions:
----------
66b11d5e8b9a015dd1b917981d9a03564bc6f16e


Modified Paths:
---------------
src/com/kodewerk/visualvm/memorypools/gc/GCView.java
src/com/kodewerk/visualvm/memorypools/gc/GarbageCollectorPosition.java


Diffs:
------
diff --git a/src/com/kodewerk/visualvm/memorypools/gc/GCView.java 
b/src/com/kodewerk/visualvm/memorypools/gc/GCView.java
index 395d10b..7d5f969 100644
--- a/src/com/kodewerk/visualvm/memorypools/gc/GCView.java
+++ b/src/com/kodewerk/visualvm/memorypools/gc/GCView.java
@@ -81,9 +81,8 @@ public class GCView extends DataSourceView {
 
     private void findGarbageCollectorsAndCreatePanels() {
         findGarbageCollectors();
-        MemoryPoolPanelPositions positions = new MemoryPoolPanelPositions();
         for (GarbageCollectorModel model : garbageCollectorModels) {
-            createGarbageCollectorPanelFor(model, positions);
+            createGarbageCollectorPanelFor(model);
         }
     }
 
@@ -98,10 +97,10 @@ public class GCView extends DataSourceView {
         }
     }
 
-    private void createGarbageCollectorPanelFor(GarbageCollectorModel model, 
MemoryPoolPanelPositions positions) {
+    private void createGarbageCollectorPanelFor(GarbageCollectorModel model) 
{
         GarbageCollectorPanel panel = new GarbageCollectorPanel();
         model.registerView(panel);
-        Point position = positions.of(model.getName());
+        Point position = GarbageCollectorPosition.of(model.getName());
         DataViewComponent.DetailsView detailsView = new 
DataViewComponent.DetailsView(
                 model.getName(), "garbage collector metrics", position.y, 
panel, null);
         dvc.addDetailsView(detailsView, position.x);
diff --git 
a/src/com/kodewerk/visualvm/memorypools/gc/GarbageCollectorPosition.java 
b/src/com/kodewerk/visualvm/memorypools/gc/GarbageCollectorPosition.java
index c053fa8..54fe13f 100644
--- a/src/com/kodewerk/visualvm/memorypools/gc/GarbageCollectorPosition.java
+++ b/src/com/kodewerk/visualvm/memorypools/gc/GarbageCollectorPosition.java
@@ -10,10 +10,10 @@ public enum GarbageCollectorPosition {
     SERIAL("Copy", DataViewComponent.TOP_LEFT),
     G1_YOUNG("G1 Young Generation", DataViewComponent.TOP_LEFT),
 
-    PS_MARK_SWEEP("PS MarkSweep", DataViewComponent.TOP_RIGHT),
-    MARK_SWEEP_COMPACT("MarkSweepCompact", DataViewComponent.TOP_RIGHT),
-    CMS("ConcurrentMarkSweep", DataViewComponent.TOP_RIGHT),
-    G1_OLD("G1 Old Generation", DataViewComponent.TOP_RIGHT),
+    PS_MARK_SWEEP("PS MarkSweep", DataViewComponent.BOTTOM_LEFT),
+    MARK_SWEEP_COMPACT("MarkSweepCompact", DataViewComponent.BOTTOM_LEFT),
+    CMS("ConcurrentMarkSweep", DataViewComponent.BOTTOM_LEFT),
+    G1_OLD("G1 Old Generation", DataViewComponent.BOTTOM_LEFT),
 
     UNKNOWN("Unknown GC", DataViewComponent.TOP_LEFT)
     ;




[memorypoolview~source-code-repository:66b11d5e] Adjusted GC graphs alignment. Young GC is top, Old/Full GC is bottom.

pingtimeout 04/16/2013
 
 
Close
loading
Please Confirm
Close