Posted: April 26, 2012 02:13 by cpratt
The units for MPE_DVR_RECORDING_LENGTH (passed to mpeos_dvrRecordingGet() returning a uint64_t) are currently specified as seconds.
However, org.ocap.shared.dvr.RecordedService.getRecordedDuration() specifies that it returns "The duration of the recording in milli-seconds."
I'm proposing the units for MPE_DVR_RECORDING_LENGTH be brought in parity with the getRecordedDuration() and return milliseconds instead of seconds. This will have an additional benefit in providing a more accurate res@duration value for HN-exported RecordingContentItems.
Index: mpe/os/include/mpeos_dvr.h =================================================================== --- mpe/os/include/mpeos_dvr.h (revision 32730) +++ mpe/os/include/mpeos_dvr.h (working copy) @@ -242,7 +242,7 @@ MPE_DVR_RECORDING_SIZE, /** - * Current length (in seconds) of this recording</td> + * Current length of the recording (in milliseconds)</td> */ MPE_DVR_RECORDING_LENGTH,
Questions and comments welcome.