Skip to main content

[JIRA] Resolved: (PORTLETSPEC3-27) Errata: PortletMode and WindowState request during resource serving wit FULL cacheability

  • From: "msnicklous (JIRA)" < >
  • To:
  • Subject: [JIRA] Resolved: (PORTLETSPEC3-27) Errata: PortletMode and WindowState request during resource serving wit FULL cacheability
  • Date: Thu, 22 Aug 2013 13:26:19 +0000 (UTC)
  • Auto-submitted: auto-generated


     [ 
https://java.net/jira/browse/PORTLETSPEC3-27?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

msnicklous resolved PORTLETSPEC3-27.
------------------------------------

    Resolution: Fixed

To start off with, I answered my own question - on a resource URL will cache 
level set to FULL, neither the render parameters nor the portlet mode or 
window state should be present, as their presence would reduce the ability of 
the URL to be cached.

Following Ed's suggestion to add a new value to the PortletMode and 
WindowState enum classes rather than return null, the values 
[PortletMode.UNDEFINED|http://msnicklous.github.io/portletspec3/javax/portlet/PortletMode.html#UNDEFINED]
 and 
[WindowState.UNDEFINED|http://msnicklous.github.io/portletspec3/javax/portlet/WindowState.html#UNDEFINED]
 were added. 

The method definitions 
[ResourceRequest.getPortletMode()|http://msnicklous.github.io/portletspec3/javax/portlet/ResourceRequest.html#getPortletMode%28%29]
 and 
[ResourceRequest.getWindowState()|http://msnicklous.github.io/portletspec3/javax/portlet/ResourceRequest.html#getWindowState%28%29]
 were added to ResourceRequest, overriding the corresponding definitions in 
PortletRequest, in order to add the description about the return value when 
the cache level is set to FULL.

I went ahead and made the change without first posting a detailed proposal, 
because I felt the basic issue was clear. Naturally, if there would be 
reasons to modify the change, we can reopen the issue.

> Errata: PortletMode and WindowState request during resource serving wit 
> FULL cacheability 
> ------------------------------------------------------------------------------------------
>
>                 Key: PORTLETSPEC3-27
>                 URL: https://java.net/jira/browse/PORTLETSPEC3-27
>             Project: portletspec3
>          Issue Type: Improvement
>          Components: JSR 286 Portlet Specification Errata
>            Reporter: julien_viet
>            Assignee: msnicklous
>            Priority: Minor
>
> During a resource serving with cacheability FULL a portlet cannot access 
> the window state and portlet mode (neither the render parameters).
> The specification says is vague and say: "Thus the portlet should not 
> access the portlet mode, window state, or render parameters in the 
> serveResource call."
> The current Javadoc does not specify anything particular , for example 
> PortletRequest#getPortletMode() say "Returns the current portlet mode of 
> the portlet" .
> I think we lack of clarity as we don't specify what 
> PortletRequest#getPortletMode() and PortletRequest#getWindowState() should 
> return in this case.
> I believe it should return null and we should say it clearly in the 
> Javadoc, for example we could redeclare those methods in the 
> ResourceRequest interface and add to the javadoc that in case of FULL 
> cacheability then null is returned.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
https://java.net/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        


[JIRA] Resolved: (PORTLETSPEC3-27) Errata: PortletMode and WindowState request during resource serving wit FULL cacheability

msnicklous (JIRA) 08/22/2013
 
 
Close
loading
Please Confirm
Close