Skip to main content

[JIRA] Commented: (XADISK-136) XADisk hangs on recovery after failed directory creation with ":"

  • From: "Nitin Verma (JIRA)" <jira-no-reply@...>
  • To: issues@...
  • Subject: [JIRA] Commented: (XADISK-136) XADisk hangs on recovery after failed directory creation with ":"
  • Date: Sun, 14 Jul 2013 13:17:58 +0000 (UTC)
  • Auto-submitted: auto-generated


    [ 
https://java.net/jira/browse/XADISK-136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=366347#action_366347
 ] 

Nitin Verma commented on XADISK-136:
------------------------------------

Thanks Gunnar. I agree the infinite loop is not a good idea; I will try to 
design some approach to take care of such transactions which are not able to 
progress (eg not able to create a file/directory, delete them etc) and, due 
to this endless loop, keep hanging and blocks the entire xadisk instance 
during recovery.

When the commit process had already started during such failure loops, going 
back to rollback is not feasible. One way is to require user/admin's 
interference to let the transaction proceed (to commit). Another issue was 
reported by Julius at https://java.net/jira/browse/XADISK-76 which would ;
require the same fix as this one.

Regards,
Nitin

> XADisk hangs on recovery after failed directory creation with ":"
> -----------------------------------------------------------------
>
>                 Key: XADISK-136
>                 URL: https://java.net/jira/browse/XADISK-136
>             Project: xadisk
>          Issue Type: Bug
>          Components: filesystem
>    Affects Versions: 1.2.1
>         Environment: Windows 7, JDK 1.6
>            Reporter: gunnar_zarncke
>            Assignee: Nitin Verma
>            Priority: Minor
>
> After trying to create a directory containing a ":" and stopping the JVM 
> the CrashRecoveryWorker hangs indefinitely in FileIOUtils.createDirectory 
> because creating the directory fails each time (due to the ":") and 
> makeSpaceForGC() is called in a loop causing the recovery to never return.
> I do not like this code. I agree that it may fail to to hanging closes 
> (which indeed may be healed by GC), but there can be other reasons (like an 
> accidental ":") which make this a dangerous construction. 
> At least I propose to add an extra exit condition (loop counter, timing, 
> ...).

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
https://java.net/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        


[JIRA] Created: (XADISK-136) XADisk hangs on recovery after failed directory creation with ":"

gunnar_zarncke (JIRA) 07/01/2013

[JIRA] Commented: (XADISK-136) XADisk hangs on recovery after failed directory creation with ":"

gunnar_zarncke (JIRA) 07/01/2013

[JIRA] Commented: (XADISK-136) XADisk hangs on recovery after failed directory creation with ":"

Nitin Verma (JIRA) 07/14/2013
 
 
Close
loading
Please Confirm
Close